Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(*): mark some classes as Prop #18015

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - fix(*): mark some classes as Prop #18015

wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 26, 2022

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Dec 26, 2022
@urkud urkud requested a review from a team as a code owner December 26, 2022 20:44
@alreadydone
Copy link
Collaborator

alreadydone commented Dec 26, 2022 •
edited

Looks good, thanks! One file has been ported to mathlib4; do those classes already live in Prop in Lean 4? If yes then no matching PR is needed, but I guess mathport checks universes as well and the answer is no.

I also spotted two other examples previously; would you include them in this PR?

@urkud urkud requested a review from a team as a code owner December 27, 2022 01:03
@urkud urkud mentioned this pull request Dec 28, 2022
Closed
alreadydone
alreadydone reviewed Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

The matching PR is not yet approved but the plan seems to be merging this first

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 29, 2022
bors bot pushed a commit that referenced this pull request Dec 29, 2022
@urkud
fix(*): mark some classes as Prop (#18015)
986c4d5
@bors
Copy link

bors bot commented Dec 29, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(*): mark some classes as Prop [Merged by Bors] - fix(*): mark some classes as Prop Dec 29, 2022
@bors bors bot closed this Dec 29, 2022
@bors bors bot deleted the YK-class-prop branch December 29, 2022 19:52
@urkud urkud mentioned this pull request Dec 30, 2022
Closed
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Dec 31, 2022
@urkud
refactor: move some classes to Prop (#1268)
53b71a9 
Also make `SubmonoidClass` extend `OneMemClass`.
This is a Lean 4 version of leanprover-community/mathlib#18015
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Dec 31, 2022
@urkud @riccardobrasca @hrmacbeth
refactor: move some classes to Prop (#1268)
70c3e2a 
Also make `SubmonoidClass` extend `OneMemClass`.
This is a Lean 4 version of leanprover-community/mathlib#18015

Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @alreadydone @jcommelin