Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(data/set/finite): add finite_to_set lemmas to simp set #18026

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - refactor(data/set/finite): add finite_to_set lemmas to simp set #18026

wants to merge 1 commit into from

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Dec 30, 2022 •
edited

Making these be simp lemmas allows simp discharge such simple set.finite side-goals.

Open in Gitpod

@kmill kmill added the awaiting-author A reviewer has asked the author a question or requested changes label Dec 30, 2022
@kmill kmill mentioned this pull request Dec 30, 2022
Closed
@kmill kmill added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 30, 2022
@alreadydone
Copy link
Collaborator

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 1, 2023
bors bot pushed a commit that referenced this pull request Jan 1, 2023
@kmill
refactor(data/set/finite): add finite_to_set lemmas to simp set (#1…
8a8ac5b 
…8026)

Making these be `simp` lemmas allows `simp` discharge such simple `set.finite` side-goals.
@bors
Copy link

bors bot commented Jan 1, 2023

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@bors bors bot changed the title refactor(data/set/finite): add finite_to_set lemmas to simp set [Merged by Bors] - refactor(data/set/finite): add finite_to_set lemmas to simp set Jan 1, 2023
@bors bors bot closed this Jan 1, 2023
@bors bors bot deleted the kmill_simp_finite_to_set branch January 1, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmill @alreadydone @riccardobrasca