Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(analysis/convex): simplify proofs, use implicit args and dot notation #1804

Merged
merged 5 commits into from Dec 16, 2019

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 15, 2019

Depends on #1803

  • Use dot notation.
  • Swap LHS and RHS of image_Icc_zero_one_eq_segment.
  • Introduce finset.center_mass, prove basic properties.
  • Deduce Jensen's inequality from the corresponding property of convex
    sets; rename corresponding lemmas.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

… notation

* Use dot notation.
* Swap LHS and RHS of `image_Icc_zero_one_eq_segment`.
* Introduce `finset.center_mass`, prove basic properties.
* Deduce Jensen's inequality from the corresponding property of convex
  sets; rename corresponding lemmas.
@urkud urkud added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 15, 2019
src/analysis/convex.lean Outdated Show resolved Hide resolved
src/analysis/convex.lean Outdated Show resolved Hide resolved
Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@urkud urkud removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 16, 2019
@sgouezel sgouezel added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Dec 16, 2019
@mergify mergify bot merged commit de25b10 into master Dec 16, 2019
@mergify mergify bot deleted the convex-review branch December 16, 2019 10:22
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
… notation (leanprover-community#1804)

* feat(data/set/intervals): add `nonempty_Icc` etc, `image_(add/mul)_(left/right)_Icc`

* refactor(analysis/convex): simplify proofs, use implicit args and  dot notation

* Use dot notation.
* Swap LHS and RHS of `image_Icc_zero_one_eq_segment`.
* Introduce `finset.center_mass`, prove basic properties.
* Deduce Jensen's inequality from the corresponding property of convex
  sets; rename corresponding lemmas.

* Fix a typo

Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr>

* Update src/analysis/convex.lean
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
… notation (leanprover-community#1804)

* feat(data/set/intervals): add `nonempty_Icc` etc, `image_(add/mul)_(left/right)_Icc`

* refactor(analysis/convex): simplify proofs, use implicit args and  dot notation

* Use dot notation.
* Swap LHS and RHS of `image_Icc_zero_one_eq_segment`.
* Introduce `finset.center_mass`, prove basic properties.
* Deduce Jensen's inequality from the corresponding property of convex
  sets; rename corresponding lemmas.

* Fix a typo

Co-Authored-By: sgouezel <sebastien.gouezel@univ-rennes1.fr>

* Update src/analysis/convex.lean
bors bot pushed a commit that referenced this pull request Sep 11, 2021
…#9115)

This moves `finset.center_mass` into its own new file.

About the copyright header, `finset.center_mass` comes from #1804, which was written by Yury in December 2019.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants