Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analysis/inner_product_space/finite_dimensional): some lemmas on finite dimensional inner product spaces #18041

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

themathqueen
Copy link
Collaborator

@themathqueen themathqueen commented Jan 2, 2023

…le for finite dimensional inner product space
@themathqueen themathqueen added WIP Work in progress awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) and removed WIP Work in progress labels Jan 2, 2023
@ADedecker ADedecker self-assigned this Jan 3, 2023
@hrmacbeth
Copy link
Member

hrmacbeth commented Jan 3, 2023

These proofs look substantially longer than I would expect. I don't have time to look at them today, unfortunately. Maybe @ADedecker has some time?

Edit: I hadn't seen that Anatole already self-assigned. Even better!

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@eric-wieser eric-wieser removed the awaiting-review The author would like community review of the PR label Jan 4, 2023
@themathqueen themathqueen added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 23, 2023
variables [ring R] [add_comm_group M] [topological_add_group M] [module R M]

/-- Given an invertible operator, multiplying it by its inverse gives the identity. -/
lemma inv_mul_self (T : M →L[R] M) [invertible T] : T.inverse * T = 1 :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we only use invertible if you use \frac1 (aka inv_of) in the statement. Since you don't, can you use is_unit T instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be easier to use \frac1 instead of inv_of everywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inv_of is to \frac1 as mul is to *. We use one in lemma names, but the other is the operator.

src/linear_algebra/invariant_submodule.lean Outdated Show resolved Hide resolved
src/linear_algebra/invariant_submodule.lean Outdated Show resolved Hide resolved
src/linear_algebra/invariant_submodule.lean Outdated Show resolved Hide resolved
src/linear_algebra/invariant_submodule.lean Outdated Show resolved Hide resolved
src/linear_algebra/invariant_submodule.lean Outdated Show resolved Hide resolved
src/linear_algebra/invariant_submodule.lean Outdated Show resolved Hide resolved
src/linear_algebra/invariant_submodule.lean Outdated Show resolved Hide resolved
Comment on lines 89 to 91
lemma submodule.commutes_with_linear_proj_iff_linear_proj_eq [invertible T] :
commute (U.subtype.comp eᵤ) T ↔
(⅟ T).comp ((U.subtype.comp eᵤ).comp T) = U.subtype.comp eᵤ :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling would be to avoid all the invertible stuff by assuming T to be linear_equiv here, but maybe that will backfire later in applications. @eric-wieser what do you think ?

@themathqueen
Copy link
Collaborator Author

@ADedecker @eric-wieser should I make a new PR only containing the invariant_submodule file?

@ADedecker
Copy link
Member

Sorry for the slow response. Yes, I think that would be nice, because this PR is getting quite large (for good reasons!)

@themathqueen themathqueen added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 25, 2023
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 25, 2023
@themathqueen themathqueen changed the title feat(analysis/inner_product_space/finite_dimensional & analysis/von_neumann_algebra/finite_dimensional): new files feat(analysis/inner_product_space/finite_dimensional): some lemmas on finite dimensional inner product spaces Jan 25, 2023
@Vierkantor Vierkantor added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 30, 2023
@eric-wieser eric-wieser added the not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 t-analysis Analysis (normed *, calculus)
Projects
linear_algebra
In progress
Development

Successfully merging this pull request may close these issues.

None yet

8 participants