[Merged by Bors] - feat(topology/algebra/module/multilinear): add continuous versions of constructions #18044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constructions One of these is a much more general case of `continuous_multilinear_map.curry0`; but to keep this PR small we don't attempt to remove `curry0`, instead just golfing it.
eric-wieser
added
easy
mathlib-dependent-issues-bot
added
the
blocked-by-other-PR
eric-wieser
removed
the
easy
mathlib-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
ADedecker
reviewed
Jan 3, 2023
| variables {M₂} | ||
| variables (M₁) {M₂} |
There was a problem hiding this comment.
I'm probably overlooking something obvious, but I can't see why you need M₁ to be explicit in const_of_is_empty
There was a problem hiding this comment.
How else would it be inferred?
There was a problem hiding this comment.
I asked that because you seem to always use _ to fill in this argument, which suggests that in all cases currently in mathlib the expected type is enough. But I get that in the middle of the proof it can be annoying to add a type annotation, so I'm okay with that.
There was a problem hiding this comment.
Ah, for this PR I needed the argument to state norm_const_of_is_empty without needing @ or annotations
ADedecker
added
awaiting-author
ADedecker
added
awaiting-review
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by ADedecker. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
… constructions (#18044) One of these is a much more general case of `continuous_multilinear_map.curry0`; but to keep this PR small we don't attempt to remove `curry0`, instead just golfing it.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of these is a much more general case of
continuous_multilinear_map.curry0; but to keep this PR small we don't attempt to removecurry0, instead just golfing it.finset.prod_of_empty#18045