[Merged by Bors] - chore(field_theory/minpoly): Split results from minpoly.lean into three files
#18048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paul-Lez
changed the title
minpoly.lean into three files minpoly.lean into three files
Paul-Lez
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
Paul-Lez
added
the
awaiting-review
Vierkantor
reviewed
Jan 3, 2023
|
LGTM, thanks! bors d+ |
|
✌️ Paul-Lez can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
Vierkantor
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
I just quickly verified nothing got left in the shuffle:
$ comm <(sort src/field_theory/minpoly.lean) <(cat src/field_theory/minpoly/*.lean | sort) -23
After stating the defining property we specialize to the setting of field extensions
and derive some well-known properties, amongst which the fact that minimal polynomials
end field
section field
under the assumption that x is integral over `A`.
variables (A x)
variables [field A]
variables [ring B] [algebra A B]
variables {x : B}
variables {x : B}So looks good to me too!
|
bors r+ |
|
Strange, the staging commit built successfully but was not merged into master. Current status is "awaiting review" at https://app.bors.tech/repositories/24316. I guess someone has to re-trigger bors. |
|
Huh strange ! I'll try again. bors r+ |
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
minpoly.lean into three files minpoly.lean into three files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we split the results contained in
minpoly.leaninto three separate files:minpoly.basic.lean,minpoly.field.leanandminpoly.gcd_monoid.lean. This is helpful for PR #18021.