Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(analysis/calculus/fderiv): prove has_fderiv_within_at.lim for any filter #1805

Merged
merged 2 commits into from
Dec 16, 2019

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 15, 2019

Also prove two versions of "directional derivative agrees with
has_fderiv_at": has_fderiv_at.lim and has_fderiv_at.lim_real.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@@ -276,6 +276,19 @@ end
lemma continuous_nnnorm : continuous (nnnorm : α → nnreal) :=
continuous_subtype_mk _ continuous_norm

/-- If `∥y∥→∞`, then we can assume `y≠x` for any fixed `x`. -/
lemma set_of_ne_mem_of_tendsto_norm_at_top {l : filter γ} {f : γ → α}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is a little bit weird. As we are not in the filter name space, what about ne_mem_filter_of_tendsto_norm_at_top?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

…for any filter

Also prove two versions of "directional derivative agrees with
`has_fderiv_at`": `has_fderiv_at.lim` and `has_fderiv_at.lim_real`.
@sgouezel sgouezel added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Dec 16, 2019
@mergify mergify bot merged commit ee981c2 into master Dec 16, 2019
@mergify mergify bot deleted the deriv-lim-filter branch December 16, 2019 07:01
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…for any filter (leanprover-community#1805)

* refactor(analysis/calculus/fderiv): prove `has_fderiv_within_at.lim` for any filter

Also prove two versions of "directional derivative agrees with
`has_fderiv_at`": `has_fderiv_at.lim` and `has_fderiv_at.lim_real`.

* Rename a lemma as suggested by @sgouezel
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…for any filter (leanprover-community#1805)

* refactor(analysis/calculus/fderiv): prove `has_fderiv_within_at.lim` for any filter

Also prove two versions of "directional derivative agrees with
`has_fderiv_at`": `has_fderiv_at.lim` and `has_fderiv_at.lim_real`.

* Rename a lemma as suggested by @sgouezel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants