Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/partial_sups): add csupr lemmas #18053

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat(order/partial_sups): add csupr lemmas #18053

wants to merge 8 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 3, 2023 •
edited by github-actions bot

@eric-wieser
fix(data/finset/basic): correct the name of finset.range_coe which …
a9a1b62 
…does not mention coercions

This also adds the missing lemma that should have had that name.
@eric-wieser
feat(order/partial_sups): add csupr lemmas
61ba97c
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-order Order hierarchy labels Jan 3, 2023
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 3, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jan 4, 2023
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 5, 2023
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

YaelDillies
YaelDillies approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I can see how those would be useful!

maintainer merge

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

jcommelin
jcommelin approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 9, 2023
bors bot pushed a commit that referenced this pull request Jan 9, 2023
@eric-wieser
feat(order/partial_sups): add csupr lemmas (#18053)
faac84f
@bors
Copy link

bors bot commented Jan 9, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 9, 2023
@eric-wieser
feat(order/partial_sups): add csupr lemmas (#18053)
dd71334
@bors
Copy link

bors bot commented Jan 9, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/partial_sups): add csupr lemmas [Merged by Bors] - feat(order/partial_sups): add csupr lemmas Jan 9, 2023
@bors bors bot closed this Jan 9, 2023
@bors bors bot deleted the eric-wieser/partial_sups-csupr branch January 9, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eric-wieser @mathlib-dependent-issues-bot @jcommelin @YaelDillies @leanprover-community-bot-assistant