[Merged by Bors] - chore({ring_theory, field_theory}/*): fix imports to make #18021 less messy #18065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paul-Lez
added
the
awaiting-CI
jcommelin
reviewed
Jan 5, 2023
jcommelin
added
the
awaiting-author
github-actions
bot
removed
the
awaiting-CI
Paul-Lez
added
awaiting-review
Vierkantor
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
So if I read the changes correctly, apart from adjusting the imports, all other changes are moving the following definitions from ring_theory/adjoin_root.lean to field_theory/minpoly/gcd_monoid.lean:
minpoly.to_adjoin.injectiveminpoly.equiv_adjoinalgebra.adjoin.power_basis'power_basis.of_gen_mem_adjoin'
Could you add this information to the PR description, for future reference?
Looks good to me otherwise, thanks!
bors d+
|
✌️ Paul-Lez can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
… messy (#18065) PR #18021 makes some changes to the theory of `minpoly`, which has the net effect that the structure of imports has to be changed for some files. This is a bit painful so I've decided to open a new PR instead of doing it in #18021. This PR also moves the following definitions from `ring_theory/adjoin_root.lean` to `field_theory/minpoly/gcd_monoid.lean`: - minpoly.to_adjoin.injective - minpoly.equiv_adjoin - algebra.adjoin.power_basis' - power_basis.of_gen_mem_adjoin' Co-authored-by: Paul Lezeau <paul.lezeau@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #18021 makes some changes to the theory of
minpoly, which has the net effect that the structure of imports has to be changed for some files. This is a bit painful so I've decided to open a new PR instead of doing it in #18021. This PR also moves the following definitions fromring_theory/adjoin_root.leantofield_theory/minpoly/gcd_monoid.lean: