Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(geometry/euclidean/angle/unoriented/affine): more collinearity lemmas #18069

Closed
wants to merge 1 commit into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Jan 5, 2023

These lemmas relating collinearity and angles of zero or pi are less general than the existing
collinear_iff_eq_or_eq_or_angle_eq_zero_or_angle_eq_pi from which they are deduced, but may be more convenient to use. Suggested by review of #17993.


Open in Gitpod

…emmas

These lemmas relating collinearity and angles of zero or pi are less
general than the existing
`collinear_iff_eq_or_eq_or_angle_eq_zero_or_angle_eq_pi` from which
they are deduced, but may be more convenient to use.  Suggested by
review of #17993.
@jsm28 jsm28 added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jan 5, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks! Can you add similar lemmas for oangle in a later PR?

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 12, 2023
@jsm28
Copy link
Collaborator Author

jsm28 commented Jan 12, 2023

I've noted adding oangle variants of these lemmas on my (long) geometry todo list, which also has a more general point about ensuring oriented angle equivalents of all unoriented angle API. I might not do much from that list (beyond probably splitting up some geometry files further) before the Lean 4 conversion is complete, however; even though Euclidean geometry is a long way from the rising tide of Lean 4 conversion, affine spaces probably aren't so far away, and it's common for geometry work (in general, not these specific oangle lemmas) to involve adding some affine space lemmas.

bors bot pushed a commit that referenced this pull request Jan 12, 2023
…emmas (#18069)

These lemmas relating collinearity and angles of zero or pi are less general than the existing
`collinear_iff_eq_or_eq_or_angle_eq_zero_or_angle_eq_pi` from which they are deduced, but may be more convenient to use.  Suggested by review of #17993.
@bors
Copy link

bors bot commented Jan 12, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(geometry/euclidean/angle/unoriented/affine): more collinearity lemmas [Merged by Bors] - feat(geometry/euclidean/angle/unoriented/affine): more collinearity lemmas Jan 12, 2023
@bors bors bot closed this Jan 12, 2023
@bors bors bot deleted the jsm28/collinear_angle_zero_pi branch January 12, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants