[Merged by Bors] - chore(algebra/group_ring_action/invariant): streamline imports #18092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrmacbeth
changed the title
hrmacbeth
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
hrmacbeth
added
the
awaiting-review
|
Thanks! bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 8, 2023
The only file importing `algebra/group_ring_action/invariant` was `algebra/hom/group_action`. This means that the material needing both files can safely be moved from `hom/group_action` to `group_ring_action/invariant`, while only decreasing the imports of anything else in the hierarchy. This is worth doing since `group_ring_action/invariant` has another relatively heavy import (`ring_theory/subring/pointwise`). After this rearrangement, `hom/group_action` should be ready to port.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
eric-wieser
reviewed
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only file importing
algebra/group_ring_action/invariantwasalgebra/hom/group_action. This means that the material needing both files can safely be moved fromhom/group_actiontogroup_ring_action/invariant, while only decreasing the imports of anything else in the hierarchy.This is worth doing since
group_ring_action/invarianthas another relatively heavy import (ring_theory/subring/pointwise). After this rearrangement,hom/group_actionshould be ready to port.