[Merged by Bors] - chore(*): remove some defeq abuse of ^
#18136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are various places where the proofs relied on the defeq of `^`, namely that * `rfl : x ^ 0 = 1` * `rfl : x ^ (n : ℕ) = x ^ (↑n : ℤ)` * `rfl : x ^ (n.succ : ℕ) = x * x ^ n` While exploiting defeq is not always a bad thing, in some of these cases it was clear that this wasn't intentional, and the author had not noticed that they were working with integer instead of natural powers. This change is motivated by two possible refactors: * Changing the definition of `monoid.npow_rec` to match `function.iterate` * Changing the definition of `real.has_pow` to be the elementwise power on the cauchy sequence
eric-wieser
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
|
LGTM, thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
There are various places where the proofs relied on the defeq of `^`, namely that * `rfl : x ^ 0 = 1` * `rfl : x ^ (n : ℕ) = x ^ (↑n : ℤ)` * `rfl : x ^ (n.succ : ℕ) = x * x ^ n` While exploiting defeq is not always a bad thing, in some of these cases it was clear that this wasn't intentional, and the author had not noticed that they were working with integer instead of natural powers. This change is motivated by two possible refactors: * Changing the definition of `monoid.npow_rec` to match `function.iterate` * Changing the definition of `real.has_pow` to be the elementwise power on the cauchy sequence (#8146)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
^^
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various places where the proofs relied on the defeq of
^, namely thatrfl : x ^ 0 = 1rfl : x ^ (n : ℕ) = x ^ (↑n : ℤ)rfl : x ^ (n.succ : ℕ) = x * x ^ nWhile exploiting defeq is not always a bad thing, in some of these cases it was clear that this wasn't intentional, and the author had not noticed that they were working with integer instead of natural powers.
This change is motivated by two possible refactors:
monoid.npow_recto matchfunction.iteratereal.has_powto be the elementwise power on the cauchy sequence (refactor(data/real/basic): golf the ring instance #8146)