[Merged by Bors] - feat(analysis/special_functions/pow): interaction between cpow and inv/conj
#18137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
eric-wieser
changed the title
inv and cpowcpow and inv/conj
ocfnash
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Thanks!
I was a bit surprised by some of these results for the case x.arg = π but I can't see better statements.
For example I was going to advocate demoting what we currently call log_inv_eq_ite to log_inv_eq_ite' and in its place adding:
lemma log_inv_eq_ite
log z⁻¹ = if z.arg = π then -log z + 2 * π * I else -log z` :=since values of log are really defined up to an additive action of ℤ and it feels like a bit of a coincidence that this works out to be conj.
However for the lemmas here I see no alternatives.
In any case:
bors merge
leanprover-community-bot-assistant
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cpow and inv/conjcpow and inv/conj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from #17073