Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/order/ring/with_top): ring covariance & ordered ring typeclasses for with_bot #18149

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(algebra/order/ring/with_top): ring covariance & ordered ring typeclasses for with_bot #18149

wants to merge 3 commits into from

Conversation

negiizhao
Copy link
Collaborator

@negiizhao negiizhao commented Jan 12, 2023 •
edited

@negiizhao negiizhao added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-order Order hierarchy labels Jan 12, 2023
@negiizhao negiizhao changed the title feat(algebra/order/ring/with_top): ring covariance typeclasses for with_bot feat(algebra/order/ring/with_top): ring covariance / ordered ring typeclasses for with_bot Jan 12, 2023
@negiizhao negiizhao changed the title feat(algebra/order/ring/with_top): ring covariance / ordered ring typeclasses for with_bot feat(algebra/order/ring/with_top): ring covariance & ordered ring typeclasses for with_bot Jan 12, 2023
@negiizhao negiizhao mentioned this pull request Jan 12, 2023
Closed
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jan 12, 2023
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 25, 2023
bors bot pushed a commit that referenced this pull request Jan 25, 2023
@negiizhao
feat(algebra/order/ring/with_top): ring covariance & ordered ring typ…
e7e2ba8 
…eclasses for `with_bot` (#18149)

mathlib4 PR: leanprover-community/mathlib4#1508
@bors
Copy link

bors bot commented Jan 25, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/order/ring/with_top): ring covariance & ordered ring typeclasses for with_bot [Merged by Bors] - feat(algebra/order/ring/with_top): ring covariance & ordered ring typeclasses for with_bot Jan 25, 2023
@bors bors bot closed this Jan 25, 2023
@bors bors bot deleted the FR_order_refactor20 branch January 25, 2023 14:10
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jan 25, 2023
@negiizhao @fpvandoorn
feat: ring covariance & ordered ring typeclasses for WithBot (#1508)
98bc5f2 
mathlib3 PR: leanprover-community/mathlib#18149



Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@negiizhao @fpvandoorn