Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/nat/with_bot): n < m → n + 1 ≤ m #18174

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(data/nat/with_bot): n < m → n + 1 ≤ m #18174

wants to merge 1 commit into from

Conversation

alreadydone
Copy link
Collaborator

@alreadydone alreadydone commented Jan 14, 2023 •
edited

ported in leanprover-community/mathlib4#1519

The converse is not true when n and m are both bot.

Open in Gitpod

@alreadydone alreadydone added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. mathlib4-pair labels Jan 14, 2023
This was referenced Jan 14, 2023
Closed
Closed
Multramate
Multramate approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@Multramate Multramate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 25, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jan 25, 2023
@alreadydone
feat: synchronize with mathlib3#18080/18160/18174 (#1519)
48c2c12 
- [x] leanprover-community/mathlib#18080
- [x] leanprover-community/mathlib#18160
- [ ] leanprover-community/mathlib#18174



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
bors bot pushed a commit that referenced this pull request Jan 25, 2023
@alreadydone
feat(data/nat/with_bot): n < m → n + 1 ≤ m (#18174)
12665d3 
ported in leanprover-community/mathlib4#1519
@bors
Copy link

bors bot commented Jan 25, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/with_bot): n < m → n + 1 ≤ m [Merged by Bors] - feat(data/nat/with_bot): n < m → n + 1 ≤ m Jan 25, 2023
@bors bors bot closed this Jan 25, 2023
@bors bors bot deleted the nat_with_bot_add_one_le_of_lt branch January 25, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Multramate Multramate Multramate approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alreadydone @fpvandoorn @Multramate