New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(*): add mathlib4 synchronization comments #18202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
The author would like community review of the PR
easy
< 20s of review time. See the lifecycle page for guidelines.
mathlib4-synchronization
This PR *only* adds a message to the module doc about synchronization with mathlib4
labels
Jan 18, 2023
eric-wieser
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
leanprover-community-bot-assistant
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Jan 18, 2023
bors bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following files: * `algebra.gcd_monoid.finset` * `algebra.hom.centroid` * `combinatorics.set_family.compression.down` * `control.equiv_functor.instances` * `data.fin.tuple.basic` * `data.fin_enum` * `data.finset.lattice` * `data.finset.n_ary` * `data.finset.nat_antidiagonal` * `data.finset.pairwise` * `data.finset.powerset` * `data.finset.sigma` * `data.fintype.list` * `data.fintype.sigma` * `data.list.of_fn` * `data.matrix.dmatrix` * `data.real.basic` * `data.real.sign` * `group_theory.congruence` * `group_theory.perm.support` * `order.grade` * `order.hom.bounded` * `order.sup_indep` * `ring_theory.congruence`
Build failed: |
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following files: * `algebra.gcd_monoid.finset` * `algebra.hom.centroid` * `combinatorics.set_family.compression.down` * `control.equiv_functor.instances` * `data.fin.tuple.basic` * `data.fin_enum` * `data.finset.lattice` * `data.finset.n_ary` * `data.finset.nat_antidiagonal` * `data.finset.pairwise` * `data.finset.powerset` * `data.finset.sigma` * `data.fintype.list` * `data.fintype.sigma` * `data.list.of_fn` * `data.matrix.dmatrix` * `data.real.basic` * `data.real.sign` * `group_theory.congruence` * `group_theory.perm.support` * `order.grade` * `order.hom.bounded` * `order.sup_indep` * `ring_theory.congruence`
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
chore(*): add mathlib4 synchronization comments
[Merged by Bors] - chore(*): add mathlib4 synchronization comments
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
easy
< 20s of review time. See the lifecycle page for guidelines.
mathlib4-synchronization
This PR *only* adds a message to the module doc about synchronization with mathlib4
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerated from the port status wiki page.
Relates to the following files:
algebra.gcd_monoid.finset
algebra.hom.centroid
combinatorics.set_family.compression.down
control.equiv_functor.instances
data.fin.tuple.basic
data.fin_enum
data.finset.lattice
data.finset.n_ary
data.finset.nat_antidiagonal
data.finset.pairwise
data.finset.powerset
data.finset.sigma
data.fintype.list
data.fintype.sigma
data.list.of_fn
data.matrix.dmatrix
data.real.basic
data.real.sign
group_theory.congruence
group_theory.perm.support
order.grade
order.hom.bounded
order.sup_indep
ring_theory.congruence
The following files have no module docstring, so I have not added a message in this PR
category_theory.functor.default
control.basic
Please make a PR to add a module docstring (for Lean3 and Lean4!), then I will add the freeze comment next time.
The following files no longer exist in Lean 3' mathlib, so I have not added a message in this PR
lean_core.data.vector
In future we should find where they moved to, and check that the files are still in sync.
I am a bot; please check that I have not put a comment in a bad place before running
bors merge
!