[Merged by Bors] - refactor(geometry/euclidean/angle/oriented/basic): split out rotations #18212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`geometry.euclidean.angle.oriented.basic` is 1489 lines long. Reduce it to 1032 lines by splitting out the definition of and results about `rotation` to a separate file. (No results in this file involve `rotation` in their proofs unless it's also involved in the statement.) There are no changes to API or proofs.
jsm28
added
awaiting-review
|
✌️ jsm28 can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
added
the
awaiting-CI
leanprover-community-bot-assistant
added
delegated
github-actions
bot
removed
the
awaiting-CI
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
#18212) `geometry.euclidean.angle.oriented.basic` is 1489 lines long. Reduce it to 1032 lines by splitting out the definition of and results about `rotation` to a separate file. (No results in this file involve `rotation` in their proofs unless it's also involved in the statement.) There are no changes to API or proofs.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geometry.euclidean.angle.oriented.basicis 1489 lines long. Reduce it to 1032 lines by splitting out the definition of and results aboutrotationto a separate file. (No results in this file involverotationin their proofs unless it's also involved in the statement.) There are no changes to API or proofs.