[Merged by Bors] - refactor(number_theory/primorial): split the proof, golf it #18238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
YaelDillies
approved these changes
Jan 22, 2023
Done. Also forward-ported. |
YaelDillies
reviewed
Jan 24, 2023
|
Oh wait, sorry. It seemed that merge conflicts just happened. |
YaelDillies
added
the
merge-conflict
|
I'll look into this tonight. |
urkud
removed
the
merge-conflict
|
bors d+ |
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
* Add `nat.prime.dvd_choose`, delete less general `dvd_choose_of_middling_prime`. * Add `primorial_pos`, `primorial_add`, `primorial_add_dvd`, and `primorial_add_le`. * Golf some proofs. Here is a proof of `dvd_choose_of_middling_prime` based on `nat.prime.dvd_choose`: ```lean open nat lemma dvd_choose_of_middling_prime (p : ℕ) (is_prime : nat.prime p) (m : ℕ) (p_big : m + 1 < p) (p_small : p ≤ 2 * m + 1) : p ∣ choose (2 * m + 1) (m + 1) := is_prime.dvd_choose p_big (by simpa [two_mul] using p_big.le) p_small ``` Forward-ported in leanprover-community/mathlib4#1770
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 26, 2023
This is a forward-port of leanprover-community/mathlib#18238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nat.prime.dvd_choose, delete less generaldvd_choose_of_middling_prime.primorial_pos,primorial_add,primorial_add_dvd, andprimorial_add_le.Here is a proof of
dvd_choose_of_middling_primebased onnat.prime.dvd_choose:Forward-ported in leanprover-community/mathlib4#1770