Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/group/inj_surj): Missing transfer instances #18247

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jan 20, 2023

Transfer add_comm_monoid_with_one/add_comm_group_with_one along injective/surjective functions. Also add a missing reducible tag.


Match leanprover-community/mathlib4#1725

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Jan 20, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@bors
Copy link

bors bot commented Jan 21, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 21, 2023
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 21, 2023
Transfer `add_comm_monoid_with_one`/`add_comm_group_with_one` along injective/surjective functions. Also add a missing `reducible` tag.
@bors
Copy link

bors bot commented Jan 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/group/inj_surj): Missing transfer instances [Merged by Bors] - feat(algebra/group/inj_surj): Missing transfer instances Jan 21, 2023
@bors bors bot closed this Jan 21, 2023
@bors bors bot deleted the injective_add_comm_monoid_with_one branch January 21, 2023 17:49
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Feb 17, 2023
Match leanprover-community/mathlib#18247



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
mo271 pushed a commit to leanprover-community/mathlib4 that referenced this pull request Feb 18, 2023
Match leanprover-community/mathlib#18247



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants