Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(*/finsupp/*): add missing decidable arguments in lemma statements #18251

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - fix(*/finsupp/*): add missing decidable arguments in lemma statements #18251

wants to merge 10 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 20, 2023 •
edited

I missed these files in #18241

Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jan 20, 2023
@eric-wieser eric-wieser changed the title fix(algebra/big_operators/finsupp): add missing decidable arguments in lemma statements fix(algebra/big_operators/finsupp,data/finsupp/interval): add missing decidable arguments in lemma statements Jan 20, 2023
@eric-wieser eric-wieser changed the title fix(algebra/big_operators/finsupp,data/finsupp/interval): add missing decidable arguments in lemma statements fix(*/finsupp/*): add missing decidable arguments in lemma statements Jan 20, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jan 22, 2023
sgouezel
sgouezel reviewed Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

src/data/finsupp/to_dfinsupp.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 23, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 23, 2023
@eric-wieser @sgouezel
Update src/data/finsupp/to_dfinsupp.lean
4d94824 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 23, 2023
bors bot pushed a commit that referenced this pull request Jan 23, 2023
@eric-wieser
fix(*/finsupp/*): add missing decidable arguments in lemma statements (…
6e492fd 
…#18251)

I missed these files in #18241
@bors
Copy link

bors bot commented Jan 23, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(*/finsupp/*): add missing decidable arguments in lemma statements [Merged by Bors] - fix(*/finsupp/*): add missing decidable arguments in lemma statements Jan 23, 2023
@bors bors bot closed this Jan 23, 2023
@bors bors bot deleted the eric-wieser/finsupp-decidable branch January 23, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @sgouezel @leanprover-community-bot-assistant