Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(order/filter/basic): drop a lemma #18254

Closed
wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 22, 2023

  • Drop filter.subtype_coe_map_comap_prod. This lemma was used once in mathlib and Lean 4 has no list_pair instance that is used in its statement.
  • Add uniformity_set_coe. For some reason, Lean fails to rewrite on uniformity_subtype in this context.
  • Fix&golf a proof.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order hierarchy labels Jan 22, 2023
@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 22, 2023
bors bot pushed a commit that referenced this pull request Jan 22, 2023
- Drop `filter.subtype_coe_map_comap_prod`. This lemma was used once in `mathlib` and Lean 4 has no `list_pair` instance that is used in its statement.
- Add `uniformity_set_coe`. For some reason, Lean fails to rewrite on `uniformity_subtype` in this context.
- Fix&golf a proof.
@bors
Copy link

bors bot commented Jan 22, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(order/filter/basic): drop a lemma [Merged by Bors] - refactor(order/filter/basic): drop a lemma Jan 22, 2023
@bors bors bot closed this Jan 22, 2023
@bors bors bot deleted the YK-filter-drop branch January 22, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-order Order hierarchy t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants