Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(order/filter/basic): fix a diamond #18255

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix(order/filter/basic): fix a diamond #18255

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 22, 2023

Fix non-defeq default in filter.inhabited and filter.unique.

Open in Gitpod

@urkud
fix(order/filter/basic): fix a diamond
d72e7f6 
Fix non-defeq `default` in `filter.inhabited` and `filter.unique`.
@urkud urkud added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order hierarchy labels Jan 22, 2023
YaelDillies
YaelDillies approved these changes Jan 22, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 22, 2023
bors bot pushed a commit that referenced this pull request Jan 22, 2023
@urkud
fix(order/filter/basic): fix a diamond (#18255)
71efed1 
Fix non-defeq `default` in `filter.inhabited` and `filter.unique`.
@bors
Copy link

bors bot commented Jan 22, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(order/filter/basic): fix a diamond [Merged by Bors] - fix(order/filter/basic): fix a diamond Jan 22, 2023
@bors bors bot closed this Jan 22, 2023
@bors bors bot deleted the YK-filter-inhab branch January 22, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

@PatrickMassot PatrickMassot Awaiting requested review from PatrickMassot

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-order Order hierarchy t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @sgouezel @YaelDillies