[Merged by Bors] - feat(ring_theory/dedekind_domain): localizing a Dedekind domain at a prime gives DVR #18264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prime gives DVR This PR shows one direction of the implication `is_dedekind_domain → is_dedekind_domain_dvr`. The first step is to show that any localization of a Dedekind domain is again Dedekind, then use the very useful `discrete_valuation_ring.tfae` to show that this implies the localization at a prime is a DVR. Beyond general usefulness, I need this for `ideal.span_norm`.
Vierkantor
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
Co-Authored-By: Riccardo Brasca <riccardo.brasca@gmail.com>
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
…prime gives DVR (#18264) This PR shows one direction of the implication `is_dedekind_domain → is_dedekind_domain_dvr`. The first step is to show that any localization of a Dedekind domain is again Dedekind, then use the very useful `discrete_valuation_ring.tfae` to show that this implies the localization at a prime is a DVR. Beyond general usefulness, I need this for `ideal.span_norm`. Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows one direction of the implication
is_dedekind_domain → is_dedekind_domain_dvr. The first step is to show that any localization of a Dedekind domain is again Dedekind, then use the very usefuldiscrete_valuation_ring.tfaeto show that this implies the localization at a prime is a DVR.Beyond general usefulness, I need this for
ideal.span_norm.