Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/real/pi): refactor Wallis formula for pi #18280

Closed
wants to merge 3 commits into from

Conversation

loefflerd
Copy link
Collaborator

This is preparation for adding Euler's sine product (whose proof is a generalisation of the proof of Wallis' formula)


Open in Gitpod

@loefflerd loefflerd marked this pull request as ready for review January 24, 2023 17:03
@loefflerd loefflerd added the awaiting-review The author would like community review of the PR label Jan 24, 2023
src/data/real/pi/wallis.lean Outdated Show resolved Hide resolved
src/data/real/pi/wallis.lean Outdated Show resolved Hide resolved
src/data/real/pi/wallis.lean Outdated Show resolved Hide resolved
src/data/real/pi/wallis.lean Outdated Show resolved Hide resolved
src/data/real/pi/wallis.lean Outdated Show resolved Hide resolved
@loefflerd
Copy link
Collaborator Author

OK, here's a new version with the changes you suggested.

@sgouezel
Copy link
Collaborator

bors d+
Thanks!

@bors
Copy link

bors bot commented Jan 26, 2023

✌️ loefflerd can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 26, 2023
@loefflerd
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 26, 2023
This is preparation for adding Euler's sine product (whose proof is a generalisation of the proof of Wallis' formula)
@bors
Copy link

bors bot commented Jan 26, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/real/pi): refactor Wallis formula for pi [Merged by Bors] - feat(data/real/pi): refactor Wallis formula for pi Jan 26, 2023
@bors bors bot closed this Jan 26, 2023
@bors bors bot deleted the DL_euler_sin_prod4 branch January 26, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants