Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(set_theory/zfc/basic): more trivial results #18294

Closed
wants to merge 6 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jan 26, 2023

This PR does multiple very simple things at once. Here's a rundown.

  • Golf Set.eq_empty.
  • Add Set.eq_empty_or_nonempty, Set.insert_nonempty, Set.singleton_nonempty, Class.mem_def, Class.not_empty_hom, Class.univ_hom, Class.empty_Cong_to_Class, Class.empty_Class_to_Cong.
  • Tag Class.mem_univ as simp.
  • Move Set.to_set_sUnion and Set.sUnion_empty, so that the theorems on singleton injectivity aren't interspersed with the union results.

Open in Gitpod

src/set_theory/zfc/basic.lean Outdated Show resolved Hide resolved
src/set_theory/zfc/basic.lean Outdated Show resolved Hide resolved
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 27, 2023
bors bot pushed a commit that referenced this pull request Jan 27, 2023
This PR does multiple very simple things at once. Here's a rundown.
- Golf `Set.eq_empty`.
- Add `Set.eq_empty_or_nonempty`, `Set.insert_nonempty`, `Set.singleton_nonempty`, `Class.mem_def`, `Class.not_empty_hom`, `Class.univ_hom`, `Class.empty_Cong_to_Class`, `Class.empty_Class_to_Cong`.
- Tag `Class.mem_univ` as `simp`.
- Move `Set.to_set_sUnion` and `Set.sUnion_empty`, so that the theorems on singleton injectivity aren't interspersed with the union results.
@bors
Copy link

bors bot commented Jan 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set_theory/zfc/basic): more trivial results [Merged by Bors] - feat(set_theory/zfc/basic): more trivial results Jan 27, 2023
@bors bors bot closed this Jan 27, 2023
@bors bors bot deleted the zfc_sInter_v2_5 branch January 27, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants