Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/convolution): integral of a convolution over positive reals #18353

Closed
wants to merge 3 commits into from

Conversation

loefflerd
Copy link
Collaborator

This PR generalises integral_convolution to consider convolutions of functions on the positive real line. (This will be used in a follow-up PR to relate the gamma and beta functions).


Open in Gitpod

@loefflerd loefflerd added the awaiting-review The author would like community review of the PR label Feb 1, 2023
@loefflerd loefflerd marked this pull request as ready for review February 1, 2023 19:07
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For usability, can you also record a lemma saying that, under your assumptions, x -> (∫ t:ℝ in 0..x, L (f t) (g (x - t)) ∂ν) is integrable on Ioi 0 (or even on the whole space, for what it's worth)? Maybe this will require splitting off a few lemmas from your proof to avoid too much code duplication, I'm not sure.

src/analysis/convolution.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 3, 2023
@loefflerd
Copy link
Collaborator Author

For usability, can you also record a lemma saying that, under your assumptions, x -> (∫ t:ℝ in 0..x, L (f t) (g (x - t)) ∂ν) is integrable on Ioi 0 (or even on the whole space, for what it's worth)? Maybe this will require splitting off a few lemmas from your proof to avoid too much code duplication, I'm not sure.

Do you have a suggestion what to call this function? Maybe "convolution_forward" or "convolution
_pos"?

@loefflerd loefflerd added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 3, 2023
@sgouezel
Copy link
Collaborator

sgouezel commented Feb 3, 2023

Rather pos_convolution: otherwise, one may confuse it with the statement that some convolution is positive. (This will be solved by Lean 4 naming convention, but we're not there yet).

@loefflerd
Copy link
Collaborator Author

Rather pos_convolution

OK, here it is then

@sgouezel
Copy link
Collaborator

sgouezel commented Feb 7, 2023

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 7, 2023
bors bot pushed a commit that referenced this pull request Feb 7, 2023
…eals (#18353)

This PR generalises `integral_convolution` to consider convolutions of functions on the positive real line. (This will be used in a follow-up PR to relate the gamma and beta functions).
@bors
Copy link

bors bot commented Feb 7, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/convolution): integral of a convolution over positive reals [Merged by Bors] - feat(analysis/convolution): integral of a convolution over positive reals Feb 7, 2023
@bors bors bot closed this Feb 7, 2023
@bors bors bot deleted the DL_convolution_Ioi branch February 7, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants