Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/localization): remove extraneous algebra_map_submonoid S M ≤ S⁰ conditions #18358

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(ring_theory/localization): remove extraneous algebra_map_submonoid S M ≤ S⁰ conditions #18358

wants to merge 2 commits into from

Conversation

alreadydone
Copy link
Collaborator

Open in Gitpod

@alreadydone alreadydone added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Feb 2, 2023
jcommelin
jcommelin approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Feb 2, 2023

✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 2, 2023
@Vierkantor
Copy link
Collaborator

CI passed so:

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Feb 2, 2023
bors bot pushed a commit that referenced this pull request Feb 2, 2023
@alreadydone
feat(ring_theory/localization): remove extraneous `algebra_map_submon…
2e59a6d 
…oid S M ≤ S⁰` conditions (#18358)
@bors
Copy link

bors bot commented Feb 2, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/localization): remove extraneous algebra_map_submonoid S M ≤ S⁰ conditions [Merged by Bors] - feat(ring_theory/localization): remove extraneous algebra_map_submonoid S M ≤ S⁰ conditions Feb 2, 2023
@bors bors bot closed this Feb 2, 2023
@bors bors bot deleted the basis_localization branch February 2, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@Vierkantor Vierkantor Awaiting requested review from Vierkantor

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alreadydone @Vierkantor @jcommelin @leanprover-community-bot-assistant