[Merged by Bors] - feat(combinatorics/simple_graph/regularity/bound): Local positivity extension
#18368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
Closed
3 tasks
b-mehta
approved these changes
Feb 5, 2023
|
|
||
| lemma coe_m_add_one_pos : 0 < (m : ℝ) + 1 := nat.cast_add_one_pos _ | ||
| lemma coe_m_add_one_pos : 0 < (m : ℝ) + 1 := by positivity |
There was a problem hiding this comment.
Do we still need this lemma at all? Even before it was just a single library result, but now looks like it might get folded into a positivity application
There was a problem hiding this comment.
Yeah, #18371 uses three times explicitly and it helps elaboration quite a lot.
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by b-mehta. |
|
Thanks, bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
… extension (#18368) I was finding myself writing long positivity proofs that relied only on a few Szemerédi Regularity Lemma-specific lemmas before applying a bunch of usual positivity lemmas. This provides a SRL-specific `positivity` extension, which I turn on locally in the files internal to the proof of SRL. It works great and has significantly reduced the clutter.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
… extension (#18368) I was finding myself writing long positivity proofs that relied only on a few Szemerédi Regularity Lemma-specific lemmas before applying a bunch of usual positivity lemmas. This provides a SRL-specific `positivity` extension, which I turn on locally in the files internal to the proof of SRL. It works great and has significantly reduced the clutter.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
… extension (#18368) I was finding myself writing long positivity proofs that relied only on a few Szemerédi Regularity Lemma-specific lemmas before applying a bunch of usual positivity lemmas. This provides a SRL-specific `positivity` extension, which I turn on locally in the files internal to the proof of SRL. It works great and has significantly reduced the clutter.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
… extension (#18368) I was finding myself writing long positivity proofs that relied only on a few Szemerédi Regularity Lemma-specific lemmas before applying a bunch of usual positivity lemmas. This provides a SRL-specific `positivity` extension, which I turn on locally in the files internal to the proof of SRL. It works great and has significantly reduced the clutter.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
positivity extensionpositivity extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was finding myself writing long positivity proofs that relied only on a few Szemerédi Regularity Lemma-specific lemmas before applying a bunch of usual positivity lemmas.
This provides a SRL-specific
positivityextension, which I turn on locally in the files internal to the proof of SRL. It works great and has significantly reduced the clutter.