Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/complex/basic): lemmas about tsum #18376

Closed
wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Feb 3, 2023

This adds lemmas about the four "basis" complex operations: re, im, of_real (coercion), and conj.

These all follow trivially from the API for continuous linear morphisms, but using those results directly gives syntacticly different terms that don't work in rewrites. Similarly, the conj lemmas follow trivially from the results about star, but conj (aka star_ring_end) is not a syntactic match for star.

This proves all the results for is_R_or_C (including a more general version of has_sum_iff), then copies across the results to complex for convenience.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Feb 3, 2023
@eric-wieser eric-wieser force-pushed the eric-wieser/complex-tsum-lemmas branch from 4eec252 to 44f4fb6 Compare February 3, 2023 17:30
@eric-wieser eric-wieser added the t-analysis Analysis (normed *, calculus) label Feb 3, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 3, 2023
@sgouezel
Copy link
Collaborator

sgouezel commented Feb 8, 2023

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 8, 2023
bors bot pushed a commit that referenced this pull request Feb 8, 2023
This adds lemmas about the four "basis" complex operations: `re`, `im`, `of_real` (coercion), and `conj`.

These all follow trivially from the API for continuous linear morphisms, but using those results directly gives syntacticly different terms that don't work in rewrites. Similarly, the conj lemmas follow trivially from the results about `star`, but `conj` (aka `star_ring_end`) is not a syntactic match for `star`.

This proves all the results for `is_R_or_C` (including a more general version of `has_sum_iff`), then copies across the results to `complex` for convenience.
@bors
Copy link

bors bot commented Feb 8, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/complex/basic): lemmas about tsum [Merged by Bors] - feat(analysis/complex/basic): lemmas about tsum Feb 8, 2023
@bors bors bot closed this Feb 8, 2023
@bors bors bot deleted the eric-wieser/complex-tsum-lemmas branch February 8, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants