New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(algebra/algebra/operations): the semiring of submodules over an algebra is idempotent #18400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…algebra is idempotent
eric-wieser
added
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
labels
Feb 8, 2023
eric-wieser
added
the
modifies-synchronized-file
This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
label
Feb 8, 2023
YaelDillies
reviewed
Feb 8, 2023
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Feb 9, 2023
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 9, 2023
1 task
YaelDillies
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
maintainer merge
maintainer merge (seems not to work in review comments) |
🚀 Pull request has been placed on the maintainer queue by eric-wieser. |
bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 16, 2023
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
…algebra is idempotent (#18400) The same results are repeated for `ideal`. The two modifications of ported files are docstrings only, and are forward-ported at leanprover-community/mathlib4#2175. Since this adjusts the import hierarchy slightly, there are some files which now need to qualify names that were previously unambiguous. One proof timed out, but the timeout went away after converting a messy term into tactic mode.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(algebra/algebra/operations): the semiring of submodules over an algebra is idempotent
[Merged by Bors] - feat(algebra/algebra/operations): the semiring of submodules over an algebra is idempotent
Feb 16, 2023
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
cf. #18400 (review) as reviews can only be posted on pr's we don't need these checks, and they were stopping the actions from firing.
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 17, 2023
mo271
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
modifies-synchronized-file
This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR.
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
t-algebra
Algebra (groups, rings, fields etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same results are repeated for
ideal
.The two modifications of ported files are docstrings only, and are forward-ported at leanprover-community/mathlib4#2175.
Since this adjusts the import hierarchy slightly, there are some files which now need to qualify names that were previously unambiguous.
One proof timed out, but the timeout went away after converting a messy term into tactic mode.