Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(measure_theory/decomposition/unsigned_hahn): speedup Hahn decomposition #18419

Closed
wants to merge 2 commits into from

Conversation

sgouezel
Copy link
Collaborator

From 49s to 4s on my computer. The key point was to replace the super-slow ac_refl with abel.


Open in Gitpod

@sgouezel sgouezel requested a review from a team as a code owner February 10, 2023 11:01
@sgouezel sgouezel added awaiting-review The author would like community review of the PR t-measure-probability Measure theory / Probability theory easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 10, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 10, 2023
bors bot pushed a commit that referenced this pull request Feb 10, 2023
…position (#18419)

From 49s to 4s on my computer. The key point was to replace the super-slow `ac_refl` with `abel`.
@bors
Copy link

bors bot commented Feb 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(measure_theory/decomposition/unsigned_hahn): speedup Hahn decomposition [Merged by Bors] - chore(measure_theory/decomposition/unsigned_hahn): speedup Hahn decomposition Feb 10, 2023
@bors bors bot closed this Feb 10, 2023
@bors bors bot deleted the SG_speedup_hahn branch February 10, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants