Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(algebra/group/units): is_add_unit.decidable #18439

Closed
wants to merge 1 commit into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky commented Feb 14, 2023

Missing to_additive

I had actually added this to mathlib4 3 months ago in leanprover-community/mathlib4@cbc0834 (leanprover-community/mathlib4#549), and never noticed it wasn't in mathlib3.

mathlib4 hash-update placeholder pr: leanprover-community/mathlib4#2278


Open in Gitpod

Missing `to_additive`

I had actually added this to mathlib4 3 months ago,
never noticed it wasn't in mathlib3
@pechersky pechersky added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Feb 14, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 14, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Can you find the corresponding mathlib4 PR or commit and include a reference to it in the description?

Please also create a placeholder mathlib4 PR to forward-port the SHA change.

@bors
Copy link

bors bot commented Feb 14, 2023

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 14, 2023
@pechersky
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 14, 2023
Missing `to_additive`

I had actually added this to mathlib4 3 months ago in leanprover-community/mathlib4@cbc0834 (leanprover-community/mathlib4#549), and never noticed it wasn't in mathlib3.

mathlib4 hash-update placeholder pr: leanprover-community/mathlib4#2278
@bors
Copy link

bors bot commented Feb 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/group/units): is_add_unit.decidable [Merged by Bors] - chore(algebra/group/units): is_add_unit.decidable Feb 14, 2023
@bors bors bot closed this Feb 14, 2023
@bors bors bot deleted the pechersky/is-add-unit-decidable branch February 14, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants