[Merged by Bors] - feat(algebra/quaternion): add quaternion.im for the skew-adjoint part
#18456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
6 tasks
YaelDillies
reviewed
Feb 16, 2023
Comment on lines
+90
to
+93
| @[simp] lemma im_re : a.im.re = 0 := rfl | ||
| @[simp] lemma im_im_i : a.im.im_i = a.im_i := rfl | ||
| @[simp] lemma im_im_j : a.im.im_j = a.im_j := rfl | ||
| @[simp] lemma im_im_k : a.im.im_k = a.im_k := rfl |
There was a problem hiding this comment.
All those names look backward to me. Is that the naming convention for quaternions?
There was a problem hiding this comment.
Yes, unfortunately the names in this file are all over the place WRT naming order for dot notation. I can fix the names in a follow-up PR.
eric-wieser
commented
Feb 16, 2023
github-actions
bot
removed
the
awaiting-CI
YaelDillies
reviewed
Feb 16, 2023
eric-wieser
force-pushed
the
eric-wieser/quaternion.im
branch
from
bea6dce
to
9f450b8
Compare
YaelDillies
approved these changes
Feb 17, 2023
YaelDillies
reviewed
Feb 24, 2023
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2023
…rt (#18456) As requested by @YaelDillies, as prework for #18349 where I need to split the quaternion into real and imaginary parts. Only one marginally interesting lemma is included, `im_sq` which says `q.im^2 = -norm_sq q.im`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
quaternion.im for the skew-adjoint partquaternion.im for the skew-adjoint part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @YaelDillies, as prework for #18349 where I need to split the quaternion into real and imaginary parts.
Only one marginally interesting lemma is included,
im_sqwhich saysq.im^2 = -norm_sq q.im