[Merged by Bors] - feat(number_theory/diophantine_approximation): add Legendre's thm on rat'l approximations #18460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelStollBayreuth
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Feb 19, 2023
tb65536
reviewed
Mar 9, 2023
tb65536
reviewed
Mar 9, 2023
YaelDillies
reviewed
Mar 28, 2023
kbuzzard
reviewed
May 8, 2023
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by kbuzzard. |
Vierkantor
approved these changes
May 10, 2023
|
✌️ MichaelStollBayreuth can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 10, 2023
…rat'l approximations (#18460) This adds *Legendre's Theorem* on rational approximations: ```lean lemma ex_continued_fraction_convergent_eq_rat {ξ : ℝ} {q : ℚ} (h : |ξ - q| < 1 / (2 * q.denom ^ 2)) : ∃ n, (generalized_continued_fraction.of ξ).convergents n = q ``` See this [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/Diophantine.20approximation/near/323758115). Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Legendre's Theorem on rational approximations:
See this Zulip thread.