Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(number_theory/number_field/embeddings): some additional lemmas #18473

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(number_theory/number_field/embeddings): some additional lemmas #18473

wants to merge 3 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Feb 21, 2023 •
edited
Loading

Add some small lemmas that will be useful for other PRs.

Open in Gitpod

This was referenced Feb 21, 2023
Closed
Closed
@xroblot xroblot added WIP Work in progress t-number-theory Number theory (also use t-algebra or t-analysis to specialize) labels Feb 21, 2023
@xroblot xroblot marked this pull request as ready for review February 24, 2023 13:02
@xroblot xroblot added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Feb 24, 2023
@xroblot xroblot linked an issue Feb 24, 2023 that may be closed by this pull request
Proof that the unit group of a number field is finitely-generated #18482
Closed
@xroblot xroblot removed a link to an issue Feb 24, 2023
Proof that the unit group of a number field is finitely-generated #18482
Closed
ericrbg
ericrbg reviewed Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

src/number_theory/number_field/embeddings.lean Outdated Show resolved Hide resolved
@riccardobrasca
Copy link
Member

LGTM, thanks!

bors d+

@bors
Copy link

bors bot commented Feb 24, 2023

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 24, 2023
@xroblot
Copy link
Collaborator Author

xroblot commented Feb 24, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 24, 2023
@xroblot
feat(number_theory/number_field/embeddings): some additional lemmas (#…
271bf17 
…18473)

Add some small lemmas that will be useful for other PRs.
@bors
Copy link

bors bot commented Feb 24, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(number_theory/number_field/embeddings): some additional lemmas [Merged by Bors] - feat(number_theory/number_field/embeddings): some additional lemmas Feb 24, 2023
@bors bors bot closed this Feb 24, 2023
@bors bors bot deleted the xfr-update_embeddings branch February 24, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericrbg ericrbg ericrbg left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xroblot @riccardobrasca @ericrbg