New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(topology/uniform_space/basic): review API #18516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
labels
Feb 28, 2023
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Feb 28, 2023
Closed
4 tasks
jcommelin
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
leanprover-community-bot-assistant
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 1, 2023
bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
### API about uniform embeddings * Add `mk_iff` to `uniform_inducing` and `uniform_embedding`. * Move lemmas about `uniform_inducing` up. * Add `uniform_inducing.comap_uniform_space`, `uniform_inducing_iff'`, and `filter.has_basis.uniform_inducing_iff`. * Add `uniform_embedding_iff'`, `filter.has_basis.uniform_embedding_iff'`, and `filter.has_basis.uniform_embedding_iff`. * Drop `uniform_embedding_def` and `uniform_embedding_def'`. * Add `uniform_embedding_iff_uniform_inducing`. ### Other changes * Add `rescale_to_shell_semi_normed_zpow` and `rescale_to_shell_zpow`. * Generalize `continuous_linear_map.antilipschitz_of_uniform_embedding` to `continuous_linear_map.antilipschitz_of_embedding`, add an even more general version `linear_map.antilipschitz_of_comap_nhds_le`. * Use `fully_applied := ff` to generate `equiv.prod_congr_apply`. * Use `edist := λ _ _, 0` in `metric_space` instances for `empty` and `punit`. * Add `inducing.injective`, `inducing.embedding`, and `embedding_iff_inducing` * Allow `Sort*`s in `filter.has_basis.uniform_continuous_iff` and `filter.has_basis.uniform_continuous_on_iff`. * Rename * `metric.of_t0_pseudo_metric_space` to `metric_space.of_t0_pseudo_metric_space`; * `emetric.of_t0_pseudo_emetric_space` to `emetric_space.of_t0_pseudo_emetric_space`; * `metric.metric_space.to_emetric_space` to `metric_space.to_emetric_space`; * `uniform_embedding_iff'` to `emetric.uniform_embedding_iff'`
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
refactor(topology/uniform_space/basic): review API
[Merged by Bors] - refactor(topology/uniform_space/basic): review API
Mar 1, 2023
urkud
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 2, 2023
Forward-port leanprover-community/mathlib#18516 * [`logic.equiv.basic`@`d6aae1bcbd04b8de2022b9b83a5b5b10e10c777d`..`195fcd60ff2bfe392543bceb0ec2adcdb472db4c`](https://leanprover-community.github.io/mathlib-port-status/file/logic/equiv/basic?range=d6aae1bcbd04b8de2022b9b83a5b5b10e10c777d..195fcd60ff2bfe392543bceb0ec2adcdb472db4c) * [`topology.separation`@`92ca63f0fb391a9ca5f22d2409a6080e786d99f7`..`195fcd60ff2bfe392543bceb0ec2adcdb472db4c`](https://leanprover-community.github.io/mathlib-port-status/file/topology/separation?range=92ca63f0fb391a9ca5f22d2409a6080e786d99f7..195fcd60ff2bfe392543bceb0ec2adcdb472db4c) * [`topology.uniform_space.basic`@`e1a7bdeb4fd826b7e71d130d34988f0a2d26a177`..`195fcd60ff2bfe392543bceb0ec2adcdb472db4c`](https://leanprover-community.github.io/mathlib-port-status/file/topology/uniform_space/basic?range=e1a7bdeb4fd826b7e71d130d34988f0a2d26a177..195fcd60ff2bfe392543bceb0ec2adcdb472db4c) * [`topology.uniform_space.uniform_embedding`@`2705404e701abc6b3127da906f40bae062a169c9`..`195fcd60ff2bfe392543bceb0ec2adcdb472db4c`](https://leanprover-community.github.io/mathlib-port-status/file/topology/uniform_space/uniform_embedding?range=2705404e701abc6b3127da906f40bae062a169c9..195fcd60ff2bfe392543bceb0ec2adcdb472db4c)
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 2, 2023
Forward-port leanprover-community/mathlib#18516 * [`logic.equiv.basic`@`d6aae1bcbd04b8de2022b9b83a5b5b10e10c777d`..`195fcd60ff2bfe392543bceb0ec2adcdb472db4c`](https://leanprover-community.github.io/mathlib-port-status/file/logic/equiv/basic?range=d6aae1bcbd04b8de2022b9b83a5b5b10e10c777d..195fcd60ff2bfe392543bceb0ec2adcdb472db4c) * [`topology.separation`@`92ca63f0fb391a9ca5f22d2409a6080e786d99f7`..`195fcd60ff2bfe392543bceb0ec2adcdb472db4c`](https://leanprover-community.github.io/mathlib-port-status/file/topology/separation?range=92ca63f0fb391a9ca5f22d2409a6080e786d99f7..195fcd60ff2bfe392543bceb0ec2adcdb472db4c) * [`topology.uniform_space.basic`@`e1a7bdeb4fd826b7e71d130d34988f0a2d26a177`..`195fcd60ff2bfe392543bceb0ec2adcdb472db4c`](https://leanprover-community.github.io/mathlib-port-status/file/topology/uniform_space/basic?range=e1a7bdeb4fd826b7e71d130d34988f0a2d26a177..195fcd60ff2bfe392543bceb0ec2adcdb472db4c) * [`topology.uniform_space.uniform_embedding`@`2705404e701abc6b3127da906f40bae062a169c9`..`195fcd60ff2bfe392543bceb0ec2adcdb472db4c`](https://leanprover-community.github.io/mathlib-port-status/file/topology/uniform_space/uniform_embedding?range=2705404e701abc6b3127da906f40bae062a169c9..195fcd60ff2bfe392543bceb0ec2adcdb472db4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API about uniform embeddings
mk_iff
touniform_inducing
anduniform_embedding
.uniform_inducing
up.uniform_inducing.comap_uniform_space
,uniform_inducing_iff'
, andfilter.has_basis.uniform_inducing_iff
.uniform_embedding_iff'
,filter.has_basis.uniform_embedding_iff'
, andfilter.has_basis.uniform_embedding_iff
.uniform_embedding_def
anduniform_embedding_def'
.uniform_embedding_iff_uniform_inducing
.Other changes
rescale_to_shell_semi_normed_zpow
andrescale_to_shell_zpow
.continuous_linear_map.antilipschitz_of_uniform_embedding
tocontinuous_linear_map.antilipschitz_of_embedding
, add an even more general versionlinear_map.antilipschitz_of_comap_nhds_le
.fully_applied := ff
to generateequiv.prod_congr_apply
.edist := λ _ _, 0
inmetric_space
instances forempty
andpunit
.inducing.injective
,inducing.embedding
, andembedding_iff_inducing
Sort*
s infilter.has_basis.uniform_continuous_iff
andfilter.has_basis.uniform_continuous_on_iff
.metric.of_t0_pseudo_metric_space
tometric_space.of_t0_pseudo_metric_space
;emetric.of_t0_pseudo_emetric_space
toemetric_space.of_t0_pseudo_emetric_space
;metric.metric_space.to_emetric_space
tometric_space.to_emetric_space
;uniform_embedding_iff'
toemetric.uniform_embedding_iff'