Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(topology/uniform_space/basic): review API #18516

Closed
wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 28, 2023

API about uniform embeddings

  • Add mk_iff to uniform_inducing and uniform_embedding.
  • Move lemmas about uniform_inducing up.
  • Add uniform_inducing.comap_uniform_space, uniform_inducing_iff', and filter.has_basis.uniform_inducing_iff.
  • Add uniform_embedding_iff', filter.has_basis.uniform_embedding_iff', and filter.has_basis.uniform_embedding_iff.
  • Drop uniform_embedding_def and uniform_embedding_def'.
  • Add uniform_embedding_iff_uniform_inducing.

Other changes

  • Add rescale_to_shell_semi_normed_zpow and rescale_to_shell_zpow.
  • Generalize continuous_linear_map.antilipschitz_of_uniform_embedding to continuous_linear_map.antilipschitz_of_embedding, add an even more general version linear_map.antilipschitz_of_comap_nhds_le.
  • Use fully_applied := ff to generate equiv.prod_congr_apply.
  • Use edist := λ _ _, 0 in metric_space instances for empty and punit.
  • Add inducing.injective, inducing.embedding, and embedding_iff_inducing
  • Allow Sort*s in filter.has_basis.uniform_continuous_iff and filter.has_basis.uniform_continuous_on_iff.
  • Rename
    • metric.of_t0_pseudo_metric_space to metric_space.of_t0_pseudo_metric_space;
    • emetric.of_t0_pseudo_emetric_space to emetric_space.of_t0_pseudo_emetric_space;
    • metric.metric_space.to_emetric_space to metric_space.to_emetric_space;
    • uniform_embedding_iff' to emetric.uniform_embedding_iff'

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Feb 28, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 28, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 1, 2023
bors bot pushed a commit that referenced this pull request Mar 1, 2023
### API about uniform embeddings

* Add `mk_iff` to `uniform_inducing` and `uniform_embedding`.
* Move lemmas about `uniform_inducing` up.
* Add `uniform_inducing.comap_uniform_space`, `uniform_inducing_iff'`, and `filter.has_basis.uniform_inducing_iff`.
* Add `uniform_embedding_iff'`, `filter.has_basis.uniform_embedding_iff'`, and `filter.has_basis.uniform_embedding_iff`.
* Drop `uniform_embedding_def` and `uniform_embedding_def'`.
* Add `uniform_embedding_iff_uniform_inducing`.

### Other changes

* Add `rescale_to_shell_semi_normed_zpow` and `rescale_to_shell_zpow`.
* Generalize `continuous_linear_map.antilipschitz_of_uniform_embedding` to `continuous_linear_map.antilipschitz_of_embedding`, add an even more general version `linear_map.antilipschitz_of_comap_nhds_le`.
* Use `fully_applied := ff` to generate `equiv.prod_congr_apply`.
* Use `edist := λ _ _, 0` in `metric_space` instances for `empty` and `punit`.
* Add `inducing.injective`, `inducing.embedding`, and `embedding_iff_inducing`
* Allow `Sort*`s in `filter.has_basis.uniform_continuous_iff` and `filter.has_basis.uniform_continuous_on_iff`.
* Rename
  *  `metric.of_t0_pseudo_metric_space` to `metric_space.of_t0_pseudo_metric_space`;
  * `emetric.of_t0_pseudo_emetric_space` to `emetric_space.of_t0_pseudo_emetric_space`;
  * `metric.metric_space.to_emetric_space` to `metric_space.to_emetric_space`;
  * `uniform_embedding_iff'` to `emetric.uniform_embedding_iff'`
@bors
Copy link

bors bot commented Mar 1, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(topology/uniform_space/basic): review API [Merged by Bors] - refactor(topology/uniform_space/basic): review API Mar 1, 2023
@bors bors bot closed this Mar 1, 2023
@bors bors bot deleted the YK-unif-ind-iff branch March 1, 2023 21:21
urkud added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 2, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants