Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - doc(set_theory/ordinal/exponential): improve module docstring #18522

Closed
wants to merge 4 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Mar 1, 2023

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. docs This PR is about documentation modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. labels Mar 1, 2023
In this file we define the power function and the logarithm function on ordinals,

In this file we define the power function and the logarithm function on ordinals. The two are
related by the lemma `ordinal.lt_opow_iff_log_lt : x < (b^c) ↔ log b x < c` for nontrivial inputs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the ≤ version a stronger characterization?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're entirely equivalent, but to be fair we do prove the version before.

@eric-wieser
Copy link
Member

bors merge

Thanks!

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 1, 2023
@bors
Copy link

bors bot commented Mar 1, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title doc(set_theory/ordinal/exponential): improve module docstring [Merged by Bors] - doc(set_theory/ordinal/exponential): improve module docstring Mar 1, 2023
@bors bors bot closed this Mar 1, 2023
@bors bors bot deleted the exp_doc branch March 1, 2023 14:37
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 18, 2023
Pair: leanprover-community/mathlib#18522



Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This PR is about documentation easy < 20s of review time. See the lifecycle page for guidelines. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants