[Merged by Bors] - chore(*): golf using acc_lift₂_iff and well_founded_lift₂_iff
#18526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negiizhao
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Mar 1, 2023
eric-wieser
reviewed
Mar 2, 2023
src/order/rel_iso/basic.lean
Outdated
| /-- `quotient.out` as a relation embedding between the lift of a relation and the relation. -/ | ||
| @[simps] noncomputable def _root_.quotient.out_rel_embedding [s : setoid α] {r : α → α → Prop} (H) : | ||
| @[simps] noncomputable def _root_.quotient.out_rel_embedding {s : setoid α} {r : α → α → Prop} (H) : |
There was a problem hiding this comment.
I think arguably [] was better, as it matches how lift₂ is defined. Is this change actually needed to make the rest of this PR work?
There was a problem hiding this comment.
Yes. antisymm_rel.setoid is not an instance.
There was a problem hiding this comment.
I pushed some primed versions of the lemmas using {} to match the quotient.mk / quotient.mk' distinction.
bors d+
|
✌️ negiizhao can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
reviewed
Mar 15, 2023
eric-wieser
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
…8526) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
acc_lift₂_iff and well_founded_lift₂_iffacc_lift₂_iff and well_founded_lift₂_iff
YaelDillies
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a further attempt in #18128, but maybe this is enough for many cases now.