Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data.polynomial.div): add theorem X_pow_dvd_iff #18528

Closed
wants to merge 5 commits into from

Conversation

faenuccio
Copy link
Collaborator

Add the theorem X_pow_dvd_iff saying that a polynomial is divisible by $X^n$ if and only if its first $(n-1)$ coefficients are $0$.


Open in Gitpod

@faenuccio faenuccio added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Mar 1, 2023
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

src/data/polynomial/div.lean Outdated Show resolved Hide resolved
src/data/polynomial/div.lean Outdated Show resolved Hide resolved
src/data/polynomial/div.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Mar 1, 2023

✌️ faenuccio can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 1, 2023
faenuccio and others added 4 commits March 1, 2023 16:10
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@faenuccio
Copy link
Collaborator Author

Thanks!

bors d+

OK, I think this works but since there were changes I am not delegated any more to merge.

@eric-wieser
Copy link
Member

bors merge

Note that bors would definitely have allowed you to merge this yourself; and certainly I think @Vierkantor's intent was for you to do so, but no harm in being cautious!

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 1, 2023
bors bot pushed a commit that referenced this pull request Mar 1, 2023
Add the `theorem X_pow_dvd_iff` saying that a polynomial is divisible by $X^n$ if and only if its first $(n-1)$ coefficients are $0$.
@bors
Copy link

bors bot commented Mar 2, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data.polynomial.div): add theorem X_pow_dvd_iff [Merged by Bors] - feat(data.polynomial.div): add theorem X_pow_dvd_iff Mar 2, 2023
@bors bors bot closed this Mar 2, 2023
@bors bors bot deleted the powX_dvd branch March 2, 2023 00:11
@faenuccio
Copy link
Collaborator Author

bors merge

Note that bors would definitely have allowed you to merge this yourself; and certainly I think @Vierkantor's intent was for you to do so, but no harm in being cautious!

Oh, I see, I thought that the delegation was only for one commit, and then if successive commits were added (as in this case) it would lose its value. Because the red warning "you are not able to merge" was back again after I pushed new commits. I will try on another PR! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants