[Merged by Bors] - chore(algebra/algebra/restrict_scalars): replace restrict_scalars_smul_def with version that does not commit defeq-abuse.
#18540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_def`. This lemma abuses definitional equality and I think we are better without it. My immediate motivation is the trouble it is causing in the Mathlib4 porting PR: leanprover-community/mathlib4#2563 Note that it was only used in one place and there is a better proof.
ocfnash
added
awaiting-review
ocfnash
changed the title
restrict_scalars_smul_def.restrict_scalars_smul_def.
eric-wieser
reviewed
Mar 2, 2023
eric-wieser
approved these changes
Mar 2, 2023
|
✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
eric-wieser
reviewed
Mar 2, 2023
ocfnash
changed the title
restrict_scalars_smul_def.restrict_scalars_smul_def with version that does not commit defeq-abuse.
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors merge |
|
👎 Rejected by label |
github-actions
bot
added
the
ready-to-merge
ocfnash
removed
the
awaiting-CI
|
bors merge |
ocfnash
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 2, 2023
I'll fix the only remaining issue after leanprover-community/mathlib#18540 lands.
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
…ul_def` with version that does not commit defeq-abuse. (#18540) This lemma abuses definitional equality and I think we are better without it. My immediate motivation is the trouble it is causing in the Mathlib4 porting PR: leanprover-community/mathlib4#2563 Note that it was only used in one place and there is a better proof.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
restrict_scalars_smul_def with version that does not commit defeq-abuse.restrict_scalars_smul_def with version that does not commit defeq-abuse.
ocfnash
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 2, 2023
I did this manually --- is it possible to get mathport to do this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lemma abuses definitional equality and I think we are better without it. My immediate motivation is the trouble it is causing in the Mathlib4 porting PR: leanprover-community/mathlib4#2563
Note that it was only used in one place and there is a better proof.