Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(order/with_bot): lemmas about unbot and untop #18582

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(order/with_bot): lemmas about unbot and untop #18582

wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member

Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-order Order hierarchy modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. labels Mar 14, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 14, 2023
YaelDillies
YaelDillies approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any way to make it better.

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@fpvandoorn
Copy link
Member

bors merge

don't forget about the mathlib4 PR

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 15, 2023
bors bot pushed a commit that referenced this pull request Mar 15, 2023
@eric-wieser
chore(order/with_bot): lemmas about unbot and untop (#18582)
0111834
@bors
Copy link

bors bot commented Mar 15, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/with_bot): lemmas about unbot and untop [Merged by Bors] - chore(order/with_bot): lemmas about unbot and untop Mar 15, 2023
@bors bors bot closed this Mar 15, 2023
@bors bors bot deleted the eric-wieser/unbot-ring branch March 15, 2023 14:32
eric-wieser added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 16, 2023
@eric-wieser
feat: fowrard-port leanprover-community/mathlib#18582
0c3d56e
eric-wieser added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 16, 2023
@eric-wieser
feat: fowrard-port leanprover-community/mathlib#18582
350ba20
@eric-wieser
Copy link
Member Author

bors merge

don't forget about the mathlib4 PR

Done in leanprover-community/mathlib4#2928

bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 18, 2023
@eric-wieser
feat: forward-port leanprover-community/mathlib#18582 (#2929)
d3e03ed
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 18, 2023
@eric-wieser
feat: forward-port leanprover-community/mathlib#18582 (#2929)
0555bc8
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 18, 2023
@eric-wieser
feat: forward-port leanprover-community/mathlib#18582 (#2929)
16edf72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @fpvandoorn @YaelDillies