[Merged by Bors] - feat(geometry/manifold/vector_bundle/tangent): use the new tangent bundle definition in the library #18601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
fpvandoorn
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
|
This looks very good to me. Thanks a lot! I'd say let's merge this, but maybe @hrmacbeth wants to have a look first. |
|
@hrmacbeth, do you have more comments on the PR, or do you want some more time to look at it? Otherwise, I'll merge it in a few days. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
…ndle definition in the library (#18601) * Stop using the old tangent bundle definition, and use the new one instead * This affects `geometry.manifold.mfderiv` and later files. * We remove `cont_mdiff_at_iff_target`, which doesn't hold anymore in the new setting. * We prove `cont_mdiff_at_total_space`, which characterizes `C^n` maps into a vector bundle. We need a bunch of basic lemmas to prove this. This makes it easy to prove `smooth_zero_section`. * We move some results from `cont_mdiff_mfderiv` to `manifold/vector_bundle/basic`
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
…ndle definition in the library (#18601) * Stop using the old tangent bundle definition, and use the new one instead * This affects `geometry.manifold.mfderiv` and later files. * We remove `cont_mdiff_at_iff_target`, which doesn't hold anymore in the new setting. * We prove `cont_mdiff_at_total_space`, which characterizes `C^n` maps into a vector bundle. We need a bunch of basic lemmas to prove this. This makes it easy to prove `smooth_zero_section`. * We move some results from `cont_mdiff_mfderiv` to `manifold/vector_bundle/basic`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 24, 2023
semorrison
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2023
hrmacbeth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 10, 2023
hrmacbeth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geometry.manifold.mfderivand later files.cont_mdiff_at_iff_target, which doesn't hold anymore in the new setting.cont_mdiff_at_total_space, which characterizesC^nmaps into a vector bundle. We need a bunch of basic lemmas to prove this. This makes it easy to provesmooth_zero_section.cont_mdiff_mfderivtomanifold/vector_bundle/basicThis supersedes #18068