Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(analysis/inner_product_space/basic): explicit 𝕜 argument for innerₛₗ and innerSL #18613

Closed
wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 18, 2023

A reasonable fraction of the uses of these functions required either @ or a type annotation before this change.


Open in Gitpod

…`innerₛₗ` and `innerSL`

Pretty much every use of these functions required either `@` or a type annotation before this change.
@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Mar 18, 2023
@eric-wieser eric-wieser requested a review from a team as a code owner March 18, 2023 13:22
@eric-wieser eric-wieser changed the title chore(analysis/inner_product_space/basic): explicit 𝕜 argument for … chore(analysis/inner_product_space/basic): explicit 𝕜 argument for innerₛₗ and innerSL Mar 18, 2023
@RemyDegenne
Copy link
Collaborator

It indeed looks like a good change, given the number of type annotations needed before. Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 19, 2023
bors bot pushed a commit that referenced this pull request Mar 19, 2023
…`innerₛₗ` and `innerSL` (#18613)

A reasonable fraction of the uses of these functions required either `@` or a type annotation before this change.
@bors
Copy link

bors bot commented Mar 19, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/inner_product_space/basic): explicit 𝕜 argument for innerₛₗ and innerSL [Merged by Bors] - chore(analysis/inner_product_space/basic): explicit 𝕜 argument for innerₛₗ and innerSL Mar 19, 2023
@bors bors bot closed this Mar 19, 2023
@bors bors bot deleted the eric-wieser/innerₛₗ-explicit branch March 19, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants