Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(*): add mathlib4 synchronization comments #18630

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

Regenerated from the port status wiki page.
Relates to the following files:

  • algebra.category.Mon.basic
  • algebra.squarefree
  • category_theory.closed.monoidal
  • category_theory.single_obj
  • data.zmod.coprime
  • field_theory.perfect_closure
  • linear_algebra.invariant_basis_number
  • ring_theory.euclidean_domain
  • ring_theory.flat
  • ring_theory.int.basic
  • ring_theory.principal_ideal_domain
  • ring_theory.unique_factorization_domain

The following files have no module docstring, so I have not added a message in this PR

Please make a PR to add a module docstring (for Lean3 and Lean4!), then I will add the freeze comment next time.


The following files no longer exist in Lean 3' mathlib, so I have not added a message in this PR

In future we should find where they moved to, and check that the files are still in sync.


I am a bot; please check that I have not put a comment in a bad place before running bors merge!

@github-actions github-actions bot requested a review from a team as a code owner March 22, 2023 00:19
@github-actions github-actions bot added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. mathlib4-synchronization This PR *only* adds a message to the module doc about synchronization with mathlib4 labels Mar 22, 2023
@RemyDegenne
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 22, 2023
bors bot pushed a commit that referenced this pull request Mar 22, 2023
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following files:
* `algebra.category.Mon.basic`
* `algebra.squarefree`
* `category_theory.closed.monoidal`
* `category_theory.single_obj`
* `data.zmod.coprime`
* `field_theory.perfect_closure`
* `linear_algebra.invariant_basis_number`
* `ring_theory.euclidean_domain`
* `ring_theory.flat`
* `ring_theory.int.basic`
* `ring_theory.principal_ideal_domain`
* `ring_theory.unique_factorization_domain`
@bors
Copy link

bors bot commented Mar 22, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*): add mathlib4 synchronization comments [Merged by Bors] - chore(*): add mathlib4 synchronization comments Mar 22, 2023
@bors bors bot closed this Mar 22, 2023
@bors bors bot deleted the create-pull-request/patch branch March 22, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. mathlib4-synchronization This PR *only* adds a message to the module doc about synchronization with mathlib4 ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants