Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(analysis/normed_space/basic): introduce norm_smul_le #18650

Closed
wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 25, 2023

Currently norm_smul_le x y is just a special case of (norm_smul x y).le; but if in future we generalize normed_space to work over normed rings, it will continue to hold where norm_smul no longer does. This adjusts downstream proofs to use the weaker lemma too when the stronger one isn't needed, both so that we have less to fix if/when we make the suggested refactor, and because the new spelling is shorter.

This adds the corresponding nnnorm and dist and nndist lemmas too.


Open in Gitpod

Currently `norm_smul_le x y` is just a special case of `(norm_smul x y).le`; but if in future we generalize `normed_space` to work over normed rings, it will continue to hold where `norm_smul` no longer does.
This adjusts downstream proofs to use the weaker lemma too when the stronger one isn't needed.

This adds the corresponding `nnnorm` and `dist` and `nndist` lemmas too.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Mar 25, 2023
@eric-wieser eric-wieser requested a review from a team as a code owner March 25, 2023 08:41
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this indeed looks useful.

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 25, 2023
bors bot pushed a commit that referenced this pull request Mar 25, 2023
Currently `norm_smul_le x y` is just a special case of `(norm_smul x y).le`; but if in future we generalize `normed_space` to work over normed rings, it will continue to hold where `norm_smul` no longer does. This adjusts downstream proofs to use the weaker lemma too when the stronger one isn't needed, both so that we have less to fix if/when we make the suggested refactor, and because the new spelling is shorter.

This adds the corresponding `nnnorm` and `dist` and `nndist` lemmas too.
@bors
Copy link

bors bot commented Mar 25, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/normed_space/basic): introduce norm_smul_le [Merged by Bors] - chore(analysis/normed_space/basic): introduce norm_smul_le Mar 25, 2023
@bors bors bot closed this Mar 25, 2023
@bors bors bot deleted the eric-wieser/norm_smul_le branch March 25, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants