Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(*): Fix mistakes #18654

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(*): Fix mistakes #18654

wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Fix naming errors and non-defeq diamonds recently introduced. Those were discovered during the port.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Mar 25, 2023
eric-wieser
eric-wieser reviewed Mar 25, 2023
View reviewed changes
src/algebra/ring/defs.lean
class non_assoc_ring (α : Type*) extends
non_unital_non_assoc_ring α, non_assoc_semiring α, add_group_with_one α
non_unital_non_assoc_ring α, non_assoc_semiring α, add_comm_group_with_one α
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a forward-port of just this line and check it doesn't cause any TC problems in CI? The rest of the forward-port can be committed later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked and NonAssocRing already extends AddCommGroupWithOne.

eric-wieser
eric-wieser approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Looks good, but please check that mathlib4 CI is happy with the change to the extends clause before merging here.

@bors
Copy link

bors bot commented Mar 25, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 25, 2023
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 26, 2023
@YaelDillies
chore(*): Fix mistakes (#18654)
76de8ae 
Fix naming errors and non-defeq diamonds recently introduced. Those were discovered during the port.
@bors
Copy link

bors bot commented Mar 26, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*): Fix mistakes [Merged by Bors] - chore(*): Fix mistakes Mar 26, 2023
@bors bors bot closed this Mar 26, 2023
@bors bors bot deleted the cast_opposite_fix branch March 26, 2023 13:57
YaelDillies added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 27, 2023
@YaelDillies
chore: Fix cast mistakes
2beddb1 
Match leanprover-community/mathlib#18654

* [`algebra.group.opposite`@`acebd8d49928f6ed8920e502a6c90674e75bd441`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/opposite?range=acebd8d49928f6ed8920e502a6c90674e75bd441..76de8ae01554c3b37d66544866659ff174e66e1f)
* [`algebra.ring.defs`@`314d3a578607dbd2eb2481ab15fceeb62b36cbdb`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/ring/defs?range=314d3a578607dbd2eb2481ab15fceeb62b36cbdb..76de8ae01554c3b37d66544866659ff174e66e1f)
* [`algebra.ring.opposite`@`acebd8d49928f6ed8920e502a6c90674e75bd441`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/ring/opposite?range=acebd8d49928f6ed8920e502a6c90674e75bd441..76de8ae01554c3b37d66544866659ff174e66e1f)
* [`algebra.field.opposite`@`acebd8d49928f6ed8920e502a6c90674e75bd441`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/field/opposite?range=acebd8d49928f6ed8920e502a6c90674e75bd441..76de8ae01554c3b37d66544866659ff174e66e1f)
@YaelDillies YaelDillies mentioned this pull request Mar 27, 2023
Closed
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 27, 2023
@YaelDillies
chore: Fix cast mistakes (#3141)
d6829e6 
Match leanprover-community/mathlib#18654

* [`algebra.group.opposite`@`acebd8d49928f6ed8920e502a6c90674e75bd441`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/opposite?range=acebd8d49928f6ed8920e502a6c90674e75bd441..76de8ae01554c3b37d66544866659ff174e66e1f)
* [`algebra.ring.defs`@`314d3a578607dbd2eb2481ab15fceeb62b36cbdb`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/ring/defs?range=314d3a578607dbd2eb2481ab15fceeb62b36cbdb..76de8ae01554c3b37d66544866659ff174e66e1f)
* [`algebra.ring.opposite`@`acebd8d49928f6ed8920e502a6c90674e75bd441`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/ring/opposite?range=acebd8d49928f6ed8920e502a6c90674e75bd441..76de8ae01554c3b37d66544866659ff174e66e1f)
* [`algebra.field.opposite`@`acebd8d49928f6ed8920e502a6c90674e75bd441`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/field/opposite?range=acebd8d49928f6ed8920e502a6c90674e75bd441..76de8ae01554c3b37d66544866659ff174e66e1f)
joelriou pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 30, 2023
@YaelDillies @joelriou
chore: Fix cast mistakes (#3141)
f41bce1 
Match leanprover-community/mathlib#18654

* [`algebra.group.opposite`@`acebd8d49928f6ed8920e502a6c90674e75bd441`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/opposite?range=acebd8d49928f6ed8920e502a6c90674e75bd441..76de8ae01554c3b37d66544866659ff174e66e1f)
* [`algebra.ring.defs`@`314d3a578607dbd2eb2481ab15fceeb62b36cbdb`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/ring/defs?range=314d3a578607dbd2eb2481ab15fceeb62b36cbdb..76de8ae01554c3b37d66544866659ff174e66e1f)
* [`algebra.ring.opposite`@`acebd8d49928f6ed8920e502a6c90674e75bd441`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/ring/opposite?range=acebd8d49928f6ed8920e502a6c90674e75bd441..76de8ae01554c3b37d66544866659ff174e66e1f)
* [`algebra.field.opposite`@`acebd8d49928f6ed8920e502a6c90674e75bd441`..`76de8ae01554c3b37d66544866659ff174e66e1f`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/field/opposite?range=acebd8d49928f6ed8920e502a6c90674e75bd441..76de8ae01554c3b37d66544866659ff174e66e1f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @eric-wieser @leanprover-community-bot-assistant