Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(topology/algebra/module/strong_topology): split of local convexity #18671

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - refactor(topology/algebra/module/strong_topology): split of local convexity #18671

wants to merge 1 commit into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Mar 27, 2023

The reason for this split is not only to reduce the import tree, but also to find a good home for proving with_seminorm versions of the local convexity results.

Open in Gitpod

@mcdoll mcdoll added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-analysis Analysis (normed *, calculus) labels Mar 27, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 27, 2023
eric-wieser
eric-wieser approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

This seems like a reasonable split to me

@bors
Copy link

bors bot commented Mar 27, 2023

✌️ mcdoll can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser
Copy link
Member

Oh, CI is already green

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 27, 2023
@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 27, 2023
bors bot pushed a commit that referenced this pull request Mar 27, 2023
@mcdoll
refactor(topology/algebra/module/strong_topology): split of local con…
b8627db 
…vexity (#18671)

The reason for this split is not only to reduce the import tree, but also to find a good home for proving `with_seminorm` versions of the local convexity results.
@bors
Copy link

bors bot commented Mar 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(topology/algebra/module/strong_topology): split of local convexity [Merged by Bors] - refactor(topology/algebra/module/strong_topology): split of local convexity Mar 27, 2023
@bors bors bot closed this Mar 27, 2023
@bors bors bot deleted the mcdoll/strong_top_lcs branch March 27, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-analysis Analysis (normed *, calculus)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcdoll @eric-wieser @leanprover-community-bot-assistant