Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(analysis/locally_convex/strong_topology): generalize to semilinear maps #18679

Closed
wants to merge 4 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Mar 28, 2023

This is needed to show that the space of C-linear maps is locally convex.

Also generalizes the ring from real to a general ordered semiring, since the proofs didn't need the reals.


Open in Gitpod

@mcdoll mcdoll added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Mar 28, 2023

lemma strong_topology.locally_convex_space (𝔖 : set (set E)) (h𝔖₁ : 𝔖.nonempty)
(h𝔖₂ : directed_on (⊆) 𝔖) :
@locally_convex_space ℝ (E →L[ℝ] F) _ _ _ (strong_topology (ring_hom.id ℝ) F 𝔖) :=
@locally_convex_space ℝ (E →SL[σ] F) _ _ _ (strong_topology σ F 𝔖) :=
Copy link
Member

@eric-wieser eric-wieser Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to generalize to an arbitrary ordered_semiring R too.

I've pushed a commit; feel free to revert it (and my change to the PR description) if you think it's a bad idea

bors d+

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was not thinking about that. I think there is no applications for locally convex spaces over ordered semirings that are not the reals, but if the definition of locally convex allows for more generality, then these theorems should as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably you could work with rational coordinates in R^3, which would make sense here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're happy with the change I pushed feel free to merge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get a mail that CI went through. Does
bors merge
work in a comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that worked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the CI mail went to me because I was the one who pushed.

@bors
Copy link

bors bot commented Mar 31, 2023

✌️ mcdoll can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser eric-wieser added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 31, 2023
bors bot pushed a commit that referenced this pull request Mar 31, 2023
…ear maps (#18679)

This is needed to show that the space of C-linear maps is locally convex.

Also generalizes the ring from `real` to a general ordered semiring, since the proofs didn't need the `real`s.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Mar 31, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/locally_convex/strong_topology): generalize to semilinear maps [Merged by Bors] - chore(analysis/locally_convex/strong_topology): generalize to semilinear maps Mar 31, 2023
@bors bors bot closed this Mar 31, 2023
@bors bors bot deleted the mcdoll/strong_top_lcs_generalize branch March 31, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants