-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(field_theory/is_alg_closed/algebraic_closure): add instances normal and is_galois for algebraic closure #18730
Conversation
xroblot
commented
Apr 4, 2023
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
If it's not too much work can you add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me with Riccardo's suggestion.
bors d+
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
Ok, thanks. I'll add the |
I have made significant changes to this PR after it was delegated so I'd like to have another pair of eyes look at it before I hit the merge button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just check if infer_instance
works where it should? For example in
instance : normal k (algebraic_closure k) := is_alg_closure.normal _ _
I can confirm the instances are working: I am using them in another PR ;) |
I mean as proof of this lemma. If it does than there is no need for it. In any case this still LGTM. bors d+ |
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
Oh, yes, I see what you mean. Indeed, the proofs of Thanks! |
bors r+ |
…rmal and is_galois for algebraic closure (#18730)
Pull request successfully merged into master. Build succeeded: |
…rmal and is_galois for algebraic closure (#18730)