Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(field_theory/is_alg_closed/algebraic_closure): add instances normal and is_galois for algebraic closure #18730

Closed
wants to merge 8 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Apr 4, 2023


Open in Gitpod

@xroblot xroblot added awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Apr 4, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 4, 2023
@xroblot xroblot marked this pull request as ready for review April 4, 2023 09:58
@xroblot xroblot added the awaiting-review The author would like community review of the PR label Apr 4, 2023
@Vierkantor Vierkantor self-assigned this Apr 4, 2023
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@riccardobrasca
Copy link
Member

riccardobrasca commented Apr 4, 2023

If it's not too much work can you add the is_galois instance (if not already there) in characteristic zero?

Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me with Riccardo's suggestion.

bors d+

@bors
Copy link

bors bot commented Apr 4, 2023

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 4, 2023
@xroblot
Copy link
Collaborator Author

xroblot commented Apr 4, 2023

Thanks! Looks good to me with Riccardo's suggestion.

bors d+

Ok, thanks. I'll add the is_galois results first.

@xroblot xroblot added the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 4, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 4, 2023
@xroblot xroblot changed the title feat(field_theory/is_alg_closed/algebraic_closure): add instance normal for algebraic closure feat(field_theory/is_alg_closed/algebraic_closure): add instances normal and is_galois for algebraic closure Apr 4, 2023
@xroblot
Copy link
Collaborator Author

xroblot commented Apr 4, 2023

I have made significant changes to this PR after it was delegated so I'd like to have another pair of eyes look at it before I hit the merge button.

Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just check if infer_instance works where it should? For example in

instance : normal k (algebraic_closure k) := is_alg_closure.normal _ _

src/field_theory/galois.lean Show resolved Hide resolved
@xroblot
Copy link
Collaborator Author

xroblot commented Apr 4, 2023

Can you just check if infer_instance works where it should? For example in

instance : normal k (algebraic_closure k) := is_alg_closure.normal _ _

I can confirm the instances are working: I am using them in another PR ;)

@riccardobrasca
Copy link
Member

Can you just check if infer_instance works where it should? For example in

instance : normal k (algebraic_closure k) := is_alg_closure.normal _ _

I can confirm the instances are working: I am using them in another PR ;)

I mean as proof of this lemma. If it does than there is no need for it.

In any case this still LGTM.

bors d+

@bors
Copy link

bors bot commented Apr 5, 2023

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@xroblot
Copy link
Collaborator Author

xroblot commented Apr 5, 2023

Can you just check if infer_instance works where it should? For example in

instance : normal k (algebraic_closure k) := is_alg_closure.normal _ _

I can confirm the instances are working: I am using them in another PR ;)

I mean as proof of this lemma. If it does than there is no need for it.

Oh, yes, I see what you mean. Indeed, the proofs of normal, is_separable and is_galois can be generated automatically
by infer_instance for algebraic_closure so I'll remove those instances.

Thanks!

@xroblot
Copy link
Collaborator Author

xroblot commented Apr 5, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 5, 2023
@bors
Copy link

bors bot commented Apr 5, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/is_alg_closed/algebraic_closure): add instances normal and is_galois for algebraic closure [Merged by Bors] - feat(field_theory/is_alg_closed/algebraic_closure): add instances normal and is_galois for algebraic closure Apr 5, 2023
@bors bors bot closed this Apr 5, 2023
@bors bors bot deleted the xfr-is_alg_closure.normal branch April 5, 2023 13:19
xroblot added a commit that referenced this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants