[Merged by Bors] - refactor(linear_algebra/dimension): use rank in lemma names instead of dim
#18741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of `dim` The `dim` name is left from the previous name of the function. When that was merged with `module.rank`, we left renaming the existing lemmas as future work.
|
bors merge |
github-actions
bot
added
the
ready-to-merge
This was referenced Apr 5, 2023
bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
… of `dim` (#18741) The `dim` name is left from the previous name of the function, `vector_space.dim`. When that was merged with `module.rank` in #7322, we left renaming the existing lemmas as future work. This commit was made by replacing `(\b|(?<=_))dim(\b|(?=_))` with `rank` in the `dimension` and `finite_dimensional` files, and then manually fixing downstream breakages; it's important not to rename `power_basis.dim` at the same time! Deciding whether to move some of these to the `module` namespace is left as future work, the diff is already big enough.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
rank in lemma names instead of dimrank in lemma names instead of dim
xroblot
pushed a commit
that referenced
this pull request
Apr 23, 2023
… of `dim` (#18741) The `dim` name is left from the previous name of the function, `vector_space.dim`. When that was merged with `module.rank` in #7322, we left renaming the existing lemmas as future work. This commit was made by replacing `(\b|(?<=_))dim(\b|(?=_))` with `rank` in the `dimension` and `finite_dimensional` files, and then manually fixing downstream breakages; it's important not to rename `power_basis.dim` at the same time! Deciding whether to move some of these to the `module` namespace is left as future work, the diff is already big enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dimname is left from the previous name of the function,vector_space.dim. When that was merged withmodule.rankin #7322, we left renaming the existing lemmas as future work.This commit was made by replacing
(\b|(?<=_))dim(\b|(?=_))withrankin thedimensionandfinite_dimensionalfiles, and then manually fixing downstream breakages; it's important not to renamepower_basis.dimat the same time!Deciding whether to move some of these to the
modulenamespace is left as future work, the diff is already big enough.Due to my mistake, bors forgot about #18735. This is exactly the same commit as that PR.